Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(file_server):clicking filename/dirname makes url absolute path with a 404 code #425

Closed
yuqingc opened this issue May 21, 2019 · 2 comments

Comments

@yuqingc
Copy link
Contributor

yuqingc commented May 21, 2019

I ran the new file_server example with the --reload flag. There's a bug. When I click one of the file/dir name on the home page, the url becomes the absolute path of my OS, which leads to a 404 of that resource. In line 52 of file_server.ts, the absolute path is passed to the display function, making this error.

@yuqingc
Copy link
Contributor Author

yuqingc commented May 21, 2019

@yuqingc
Copy link
Contributor Author

yuqingc commented May 21, 2019

Modifying line 165 should work. I have tested. Should I open a PR for that?

From

fn,

to

fn.replace(currentDir, ''),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant