Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: enable NoUncheckedIndexedAccess TS compiler option #937

Closed
AZMCode opened this issue May 21, 2021 · 5 comments
Closed

todo: enable NoUncheckedIndexedAccess TS compiler option #937

AZMCode opened this issue May 21, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AZMCode
Copy link

AZMCode commented May 21, 2021

I'm aware this is a controversial topic, however I would find it useful if Deno's std library was compatible with Typescript's new noUncheckedIndexedAccess flag, since I find my projects that use it severely handicapped. I believe dropping some assertions throughout the code (after patching assert itself), or using less indexes should be enough.

@kt3k kt3k transferred this issue from denoland/std May 26, 2021
@kitsonk
Copy link
Contributor

kitsonk commented May 26, 2021

@kt3k this belongs in deno_std as it is requesting that the std library compile without diagnostics with the noUncheckedIndexedAccess flag is set to true. Similar to the std library being strict safe, etc. It has nothing to do with the Deno CLI itself.

@kt3k
Copy link
Member

kt3k commented May 26, 2021

@kitsonk Ah, I misread the issue.. Moving back to std.

@kt3k kt3k transferred this issue from denoland/deno May 26, 2021
@kitsonk kitsonk added the enhancement New feature or request label May 26, 2021
@kitsonk
Copy link
Contributor

kitsonk commented May 26, 2021

My personal opinion is that I don't mind having noUncheckedIndexedAccess "clean" code for std, I just wouldn't want to make it the default for the Deno CLI.

@iuioiua iuioiua changed the title [Feature Request] NoUncheckedIndexedAccess Support todo: enable NoUncheckedIndexedAccess TS compiler option Nov 29, 2023
@iuioiua iuioiua added the good first issue Good for newcomers label Nov 29, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Nov 29, 2023

I think we should add this. PRs are welcome!

@iuioiua
Copy link
Contributor

iuioiua commented Dec 30, 2023

Closing this in favour of #4040. Thank you for the input, guys!

@iuioiua iuioiua closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants