fix(fs/walk): yield broken symbolic links #3453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luk3skyw4lker
suggested changes
Jun 16, 2023
|
I'm going to pick this back up after #3455 is merged. That way the broken links can be returned rather than simply dropped. |
kt3k
reviewed
Jul 28, 2023
|
Hi @joehillen, are you still happy to pursue this PR? If so, can you apply Yoshiya's previous suggestion and fix the merge conflicts? |
|
@iuioiua Thank you for the reminder. I had forgotten about this. Unfortunately I'm busy most of this week, but I'll be able to pick this up later this week or next. |
|
All good! Thanks for letting me know 👍🏾 |
joehillen
force-pushed
the
fix/3452/fs-walk-broken-links
branch
from
d9796c9 to
c7fad4e
Compare
joehillen
changed the title
joehillen
force-pushed
the
fix/3452/fs-walk-broken-links
branch
3 times, most recently
from
9b5d76e to
b403074
Compare
Fixes denoland#3452 - tweak(fs/walk): use createWalkEntry() for consistency
- add `includeSymlinks` flag
joehillen
force-pushed
the
fix/3452/fs-walk-broken-links
branch
from
532b10b to
ffe5fcc
Compare
iuioiua
suggested changes
Jan 8, 2024
|
PTAL @kt3k |
|
Closing as we have better way to handle broken symlinks. See #3452 (comment) for more details. Also the API changes to expandGlob don't seem discussed very well. I don't find they are desirable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3452