Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fs): correct test names #3835

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

JakeAve
Copy link
Contributor

@JakeAve JakeAve commented Nov 22, 2023

Updating the fs test descriptions per #3754. Also creating some more parity between async and sync functions.

@JakeAve JakeAve requested a review from kt3k as a code owner November 22, 2023 02:08
@github-actions github-actions bot added the fs label Nov 22, 2023
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @JakeAve. Nit: can you please tweak the verb for async functions from throws to rejects?

fs/copy_test.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua changed the title chore(fs): Update fs test descriptions refactor(fs): correct test names Nov 23, 2023
fs/eol_test.ts Outdated Show resolved Hide resolved
fs/walk_test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you.

@iuioiua iuioiua merged commit bc540fb into denoland:main Nov 23, 2023
12 checks passed
realpha pushed a commit to realpha/deno_std that referenced this pull request Nov 24, 2023
* chore(fs): Update fs test descriptions

* fixes "throws" to "rejects" when appropriate

* Update fs/eol_test.ts

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants