Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback for not unstable (stable) runtime #9

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix fallback for not unstable (stable) runtime #9

merged 1 commit into from
Jul 30, 2021

Conversation

tscpp
Copy link
Contributor

@tscpp tscpp commented Jul 30, 2021

Fix fallback for when the runtime does not support unstable APIs. The "updateLines" method used "Deno.consoleSize" to check the amount of columns in the terminal. This has been changed to support the stable runtime by using a try-catch statement.

Fixes #8

Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliassjogreen eliassjogreen merged commit e9c1482 into denosaurs:master Jul 30, 2021
@tscpp tscpp deleted the support-stable-apis branch July 31, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'consoleSize' does not exist on type 'typeof Deno'
2 participants