Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and update dependencies (v0.1.5) #30

Closed
wants to merge 1 commit into from

Conversation

CorruptComputer
Copy link

  • Fix testing issue with Node version >= 10 (fixes Test fails with node >= 10 #29)
  • Update dependencies to fix security issues found by NPM
  • Update TravisCI to use supported versions of Node

Before:

duplexer2> npm i
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated mkdirp@0.3.0: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm notice created a lockfile as package-lock.json. You should commit this file.
added 26 packages from 295 contributors and audited 28 packages in 1.387s
found 4 vulnerabilities (2 low, 1 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

duplexer2> npm test

> duplexer2@0.1.4 test C:\Users\CorruptComputer\Desktop\duplexer2
> mocha -R tap

1..14
ok 1 duplexer2 should interact with the writable stream properly for writing
ok 2 duplexer2 should interact with the readable stream properly for reading
ok 3 duplexer2 should end the writable stream, causing it to finish
ok 4 duplexer2 should finish when the writable stream finishes
ok 5 duplexer2 should end when the readable stream ends
ok 6 duplexer2 should bubble errors from the writable stream when no behaviour is specified
ok 7 duplexer2 should bubble errors from the readable stream when no behaviour is specified
ok 8 duplexer2 should bubble errors from the writable stream when bubbleErrors is true
ok 9 duplexer2 should bubble errors from the readable stream when bubbleErrors is true
ok 10 duplexer2 should not bubble errors from the writable stream when bubbleErrors is false
ok 11 duplexer2 should not bubble errors from the readable stream when bubbleErrors is false
ok 12 duplexer2 should work with streams1
ok 13 duplexer2 should export the DuplexWrapper constructor
not ok 14 duplexer2 should not force flowing-mode
  false == null
  AssertionError [ERR_ASSERTION]: false == null
      at Context.<anonymous> (test\tests.js:195:12)
      at processImmediate (internal/timers.js:456:21)
# tests 14
# pass 13
# fail 1
npm ERR! Test failed.  See above for more details.

After:

duplexer2> npm i
npm WARN deprecated mkdirp@0.5.3: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.1 (node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 112 packages from 60 contributors and audited 214 packages in 3.716s

16 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

duplexer2> npm test

> duplexer2@0.1.4 test C:\Users\CorruptComputer\Desktop\duplexer2
> mocha -R tap

1..14
ok 1 duplexer2 should interact with the writable stream properly for writing
ok 2 duplexer2 should interact with the readable stream properly for reading
ok 3 duplexer2 should end the writable stream, causing it to finish
ok 4 duplexer2 should finish when the writable stream finishes
ok 5 duplexer2 should end when the readable stream ends
ok 6 duplexer2 should bubble errors from the writable stream when no behaviour is specified
ok 7 duplexer2 should bubble errors from the readable stream when no behaviour is specified
ok 8 duplexer2 should bubble errors from the writable stream when bubbleErrors is true
ok 9 duplexer2 should bubble errors from the readable stream when bubbleErrors is true
ok 10 duplexer2 should not bubble errors from the writable stream when bubbleErrors is false
ok 11 duplexer2 should not bubble errors from the readable stream when bubbleErrors is false
ok 12 duplexer2 should work with streams1
ok 13 duplexer2 should export the DuplexWrapper constructor
ok 14 duplexer2 should not force flowing-mode
# tests 14
# pass 14
# fail 0

Update dependencies to fix security issues found by NPM
Update TravisCI to use supported versions of Node
@CorruptComputer CorruptComputer closed this by deleting the head repository Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails with node >= 10
2 participants