VACMS-18457 Convert Event CTAs to DS action links #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
commented
Dec 19, 2024
| @@ -1,6 +1,14 @@ | |||
| import { deriveFormattedTimestamp } from './date' | |||
|
|
|||
| export function formatEventCTA(input: string): string { | |||
| if (!input) { | |||
There was a problem hiding this comment.
Extra null check here; but this function should not be called if the input is falsey.
randimays
commented
Dec 19, 2024
| @@ -75,6 +75,12 @@ export const Event = ({ | |||
| .filter(Boolean) | |||
| .join(', ') | |||
|
|
|||
| let eventCTAText = null | |||
|
|
|||
| if (eventCTA) { | |||
There was a problem hiding this comment.
This is the change from last time; we didn't have a falsey check for eventCTA
timcosgrove
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements DS web components for the CTAs on events pages.
Ticket
department-of-veterans-affairs/va.gov-cms#18457
Developer Task
Tasks
Testing Steps
Validate events pages with the various CTAs to ensure the links are working as expected.
Screenshots
Tested "Register" CTA on
/outreach-and-events/events/75551/Tested "Apply" CTA on
/outreach-and-events/events/75697/Tested "More details" CTA on
/fayetteville-coastal-health-care/events/75509/Tested "RSVP" CTA on
/outreach-and-events/events/75696/using this Tugboat: https://cms-ge7b9pce8q4gmol1r9zbhlkk6ml9ivu0.demo.cms.va.gov/Reviewer
Reviewing a PR
This section lists items that need to be checked or updated when making changes to this repository.
Standard Checks
Tasks
Merging an Approved Layout
When merging a layout, you must ensure that the content type has been turned on for
next-buildinside theCMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.
The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.
Merging a Non-Approved Layout
Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the
mainbranch. It is imperative that we do not push anything live that has not been approved.Ensure that this layout has been added to the templates.md file with the current status of the work.