Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - sev-3 - Android - Spin button change of state isn't automatically announced by TalkBack #3961

Closed
4 tasks
TKDickson opened this issue Oct 11, 2022 · 5 comments
Assignees
Labels
accessibility Accessibility awareness or needs for the ticket bug Used to identify a bug ticket that will be worked through the bug process Closed - Deployed/Fixed front-end Ticket requires front-end work sev-3 Lowest bug severity level based on QA bug severity scale - QA to assign this

Comments

@TKDickson
Copy link
Contributor

What happened?

On spin button dropdowns (think: the Cerner alert, the transferred med banner), TalkBack doesn't announce the change in state when they've been activated (unlike iOS/VoiceOver, which correctly does)

Specs:

Steps to Reproduce

  1. Health > Appointments (or messages) > swipe down to the cerner alert (starts "some of your VA health care team....")
  2. Spin button current state is correctly announced
  3. Double-tap to activate/expand the banner
  4. Screen UI changes (banner expands), but nothing is announced via screen reader

^ Repeat the above with iOS, and notice how it announces the change in state right away ("[text on banner], spin button, expanded" or "[text on banner], spin button, collapsed")

Desired behavior

Should announce the change in state right away/without further interaction with the app

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See Issue Tracking for details on Severity Levels

  • 3 - Medium

Linked to Story

Screen shot(s) and additional information

Ticket Checklist

  • Steps to reproduce are defined
  • Desired behavior is added
  • Labels added (front-end, back-end, feature, bug)
  • Linked to an Epic (General Tech/Design Debt & Maintenance)
@TKDickson TKDickson added accessibility Accessibility awareness or needs for the ticket bug Used to identify a bug ticket that will be worked through the bug process front-end Ticket requires front-end work sev-3 Lowest bug severity level based on QA bug severity scale - QA to assign this labels Oct 11, 2022
@theodur theodur self-assigned this Dec 27, 2022
@theodur
Copy link
Contributor

theodur commented Jan 4, 2023

After doing some digging, it looks like this is a React Native bug when using the expanded state in accessibilityState on Android. A fix was merged in the react-native repo, but hasn't been released yet. Once this makes it into a stable version, this issue should be resolved once we upgrade react-native to the version that contains the fix

@theodur
Copy link
Contributor

theodur commented Jan 4, 2023

Originally, I started working on a PR with a work-around for Android, but since this issue has already been fixed in the react-native repo, it's only a matter of time before it's released and we can upgrade.

It's also worth noting that this issue applies to multiple components that use the expanded accessibility state like CollapsibleAlert, CollapsibleView, and AccordionCollapsible. So the work around would need to be applied to multiple places. It's probably not worth it, considering how soon the fix in the react-native repo may be in a stable version

@theodur theodur added the blocked-external Ticket is blocked by some external (non-mobile) item label Jan 4, 2023
@theodur theodur removed the blocked-external Ticket is blocked by some external (non-mobile) item label Jan 30, 2023
@theodur
Copy link
Contributor

theodur commented Jan 30, 2023

We ended up merging the temporary solution since it could be some time until the fix is in a react-native stable version, and we upgrade to it

@TKDickson
Copy link
Contributor Author

Nice. Note to tester, #4365 being fixed means most of these won't be called spin buttons anymore when you're going through with a screen reader.

@rbontrager
Copy link
Contributor

Tabs on android are now giving the state of the tab(collapsed/expanded) when using TalkBack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility awareness or needs for the ticket bug Used to identify a bug ticket that will be worked through the bug process Closed - Deployed/Fixed front-end Ticket requires front-end work sev-3 Lowest bug severity level based on QA bug severity scale - QA to assign this
Projects
None yet
Development

No branches or pull requests

3 participants