Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Bitter-Regular font #589

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

narin
Copy link
Contributor

@narin narin commented Nov 11, 2024

Description of Change

Update components package to load Bitter-Regular font.

  • Update to mobile-assets 0.14.0 which contains Bitter-Regular.ttf
  • Add Bitter-Regular to useFonts hook in App.tsx
  • Add Bitter-Regular to stylesheet for Storybook web

Testing Packages

Screenshots/Video

Web

iOS

Android

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin marked this pull request as ready for review November 11, 2024 02:21
@narin narin requested a review from a team as a code owner November 11, 2024 02:21
@narin narin merged commit d3fd380 into main Nov 12, 2024
5 of 14 checks passed
@narin narin deleted the feature/495-narin-add-bitter-regular branch November 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants