Header megamenu: Menu links not explicitly connecting to their Promo

[jilladams]

Status

[2024-07-02] Slack message to Micah/Carol about transferring this ticket to their team repo for their Header/footer epic.
[2024-02-16] Comment in ticket to Micah in DST: Here's a ticket for your team's consideration when they componentize the header/footer.

To Do Refinement session 1/9:

• make the changes on a lower environment
• spin up a tugboat to ensure nothing is broken
• Fran to reach out to CAIA with results and ask do they want to make the changes on prod or do they need help?

Description

https://dsva.slack.com/archives/CDHBKAL9W/p1696271256885979

In the megamenu, the benefit areas can be expanded, and include a Promo block, e.g.:

The Promo block used in the menu should ideally be connected to the menu item via Drupal. But in some cases, a menu item that is displaying a Promo block in the FE does not have that Promo block relationship set in the menu item > Related Promo field. (How is the FE getting the right block to display, without this field value? Great question: content-build is reverse engineering and grabbing related promo from the Benefit page itself, when needed. More notes: https://dsva.slack.com/archives/CDHBKAL9W/p1696272554275839?thread_ts=1696271256.885979&cid=CDHBKAL9W)

Menu: https://prod.cms.va.gov/admin/structure/menu/manage/header-megamenu
Terms that display a Promo block in the FE, but do not have the value set in the Menu Item:

• Health care
• Careers / employment
• Pension
• Housing assistance
• Life insurance
• Records

User story

AS A Drupal maintainer
I WANT to ensure that data connections are established correctly in Drupal
SO THAT we don't accidentally regress the megamenu

Engineering / testing notes

It is probably simple to just select the right promo and set it in the Menu Items. But because the header works today without those field values, we want to test this locally first to make sure nothing breaks when we add the values to Drupal.

Content-build is able to successfully put promos on every hub in prod today, without the Drupal data association, via logic in this file: https://github.com/department-of-veterans-affairs/content-build/blob/main/src/site/stages/build/drupal/menus.js#L220

Per Tanner:

that getRelatedHubByPath function works because content-build queries the data for the whole site at once and stores it. so that pages object it's checking is actually:

   const pages = buildOptions.isPreviewServer
    ? contentData.data.nodes.entities
    : contentData.data.nodeQuery.entities;

which is all the node entities for the whole site. so it goes and finds the appropriate benefits hub entity and grab the promo block from that instead

Acceptance criteria

• Promo blocks are set in Related Promo for each Megamenu item that shows a Promo block today in production
• Verified pre-prod that setting these Related Promo values does not break the megamenu

[jilladams]

It's a FE task to make sure content-build doesn't get weird once these block values are added, but might need CMS people help to get that data local for testing? Not clear to me.

[FranECross]

@FranECross Split into two tickets for FE and BE. FE estimate swag 2-3

[FranECross]

@micahchiang Here's a ticket for your team's consideration when they componentize the header/footer.

[jilladams]

This came up again related to Accelerated Publishing launch: https://dsva.slack.com/archives/C01SR56755H/p1732122329103169?thread_ts=1731449060.323069&cid=C01SR56755H

The megamenu in the Accelerated Publishing build is missing the right-hand promo blocks, because in some cases those are built via content-build knowledge, and the data relationship is not established correctly in Drupal. I believe the first step here is to edit the relevant data in Drupal to make the right data associations, and then we can verify if anything is left to do. We likely need to do that in Tugboat first, to make sure it doesn't double things up in the header.

In the modern world of Header ownership:

• CAIA owns the data piece, though Sitewide can assist.
• DST owns the build & compiled presentation. Though: DST has not been onboarded to the idea of next-build at all. SO: they own the content-build in prod.

@mmiddaugh @FranECross @micahchiang for awareness. and cc @laflannery cuz I know you were gonna try to bring this up in refinement.

[jilladams]

I have made the suggested content changes in a Tugboat: https://cms-wiat77wwflrifw00ikgu4mku19x5itmk.demo.cms.va.gov/

Just requested a content release, and should be able to prove dupe promo blocks in the megamenu or not in the FE once it builds.

• If dupe promo blocks: FE work will be required to account for that in content-build, in order to make the data change in Prod, in order to fix next-build
• If no dupe promo blocks: we can make the changes in Prod CMS, close this ticket, and AP will be unblocked.

[jilladams]

No dupe blocks in the FE after a successful content-release: https://web-wiat77wwflrifw00ikgu4mku19x5itmk.demo.cms.va.gov/.

Screenshots

     

[jilladams]

I made the required block / menu item changes in Prod Drupal.

There's a content release in progress for 15 mins now, 17101. It should finish at 4pm PT.
They should roll out in content release 17102. ETA for that is ~5:15pm PT.

[jilladams]

Verified in prod, closing.