Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508-defect-3 [COGNITION]: Introduction page, links should be styled and written as links #22846

Closed
1 task
Tracked by #61722
joshkimux opened this issue Apr 7, 2021 · 2 comments
Closed
1 task
Tracked by #61722
Assignees
Labels
508-issue-cognition Cognitive considerations - https://developer.paciellogroup.com/blog/2018/03/wcag-2-1-success-criteri a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility bug Something isn't working NDBX-Bug Bug/defects related to non-disability (Pension, LGY/COE, CH31/VRE, CH36/PCPG) non-disability-benefits sitewide accessibility VRE-CH31 Veteran Readiness and Employment (CH31) vsa Work associated with the Veteran-facing Services Applications contract vsa-ebenefits eBenefits migration and transformation

Comments

@joshkimux
Copy link
Contributor

joshkimux commented Apr 7, 2021

508-defect-3

Feedback framework

  • ❗️ Must for if the feedback must be applied
  • ⚠️ Should if the feedback is best practice
  • ✔️ Consider for suggestions/enhancements

Definition of done

  1. Review and acknowledge feedback.
  2. Fix and/or document decisions made.
  3. Accessibility specialist will close ticket after reviewing documented decisions / validating fix.

Point of Contact

VFS Point of Contact: Josh Kim

Details

"Start your application without signing in" is styled as a link but is written as a button which is materially dishonest. Users may become frustrated that they are unable to open a new tab. Screen reader users may be confused that the text seems more like a link despite being announced as a button.

For more on this long-tail effort, check out our buttons vs. links Mural board and this Slack thread discussing why material honesty is so important.

"A few years at an accessibility event, a blind man was telling a story about how he was on the phone with someone who was trying to help him sign up for a service. The person on the phone told him to click the “sign up button” and he couldn’t find it because it was a link. He told the story with a lot more gravity than I can, but that was the point where I realized how important the human-human communication part of accessibility is, it’s not just machine to human." - Tim Wright

Acceptance Criteria

  • "Start your application without signing in" is written with an a tag

Environment

  • Operating System: all
  • Browser: any
  • Screenreading device: any
  • Server destination: staging

Solution (if known)

Use a instead of button

WCAG or Vendor Guidance (optional)

Screenshots or Trace Logs

Screen Shot 2021-04-07 at 12 16 28 PM

@joshkimux joshkimux added accessibility a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints 508-issue-cognition Cognitive considerations - https://developer.paciellogroup.com/blog/2018/03/wcag-2-1-success-criteri labels Apr 7, 2021
@jason-gcio jason-gcio added vsa Work associated with the Veteran-facing Services Applications contract vsa-ebenefits eBenefits migration and transformation labels Sep 16, 2021
@micahchiang
Copy link
Contributor

micahchiang commented Sep 22, 2021

@jason-gcio, @joshkimux - This ticket may no longer be relevant to the Chapter 31 form, as we no longer allow users to enter the form without first being logged in.

Screen Shot 2021-09-22 at 11 22 47 AM

Additionally, it looks like this may be fixed at the platform level already, based on this code, but perhaps double check with platform folks to confirm.

Edit: Apparently I cannot read. This issue still needs to be fixed at the platform level by probably removing the va-button-link class.

@joshkimux joshkimux added the VRE-CH31 Veteran Readiness and Employment (CH31) label Mar 14, 2023
@steele-lm steele-lm added the Umbrella Non-disability benefits team label Jun 27, 2023
@tblackwe tblackwe mentioned this issue Jun 27, 2023
24 tasks
@steele-lm steele-lm added bug Something isn't working NDBX-Bug Bug/defects related to non-disability (Pension, LGY/COE, CH31/VRE, CH36/PCPG) labels Jul 5, 2023
@ohgreatkate
Copy link
Contributor

no longer relevant, the Veteran can not proceed on this form with out logging in, and then button masked as a link has been removed.

@steele-lm steele-lm added non-disability-benefits and removed Umbrella Non-disability benefits team labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
508-issue-cognition Cognitive considerations - https://developer.paciellogroup.com/blog/2018/03/wcag-2-1-success-criteri a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility bug Something isn't working NDBX-Bug Bug/defects related to non-disability (Pension, LGY/COE, CH31/VRE, CH36/PCPG) non-disability-benefits sitewide accessibility VRE-CH31 Veteran Readiness and Employment (CH31) vsa Work associated with the Veteran-facing Services Applications contract vsa-ebenefits eBenefits migration and transformation
Projects
None yet
Development

No branches or pull requests

6 participants