Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring - Split PROD & STAGING build-error-check Canary into 2 Separate Canaries #25872

Closed
2 tasks
omgitsbillryan opened this issue Jun 9, 2021 · 3 comments
Closed
2 tasks
Labels
Awaiting Feedback this is for public websites team awaiting feedback from SMEs or other team members devops practice area categorization -- NOT a team assignment operations

Comments

@omgitsbillryan
Copy link
Contributor

The Problem

The build-error-check AWS Synthetic Canary currently checks both staging.va.gov & va.gov. Each env should have it's own canary so they can have different alert rules & thresholds.

Extra Context

This could easily be done by using canary ENV variables - each canary would share the same JS code but have different ENV values. However, ENV vars for canaries are currently not supported in terraform. We could manually set these ENV vars in the AWS Canary UI, but they would get wiped each time the terraform for that canary gets applied.

The other alternative would be to duplicate the javascript code on our side - one for each canary. I opted against this and chose instead to just keep 1 canary that checks both envs.

Work to be Done

  • Have 2 separate canaries running, one for staging and one for prod
  • Each canary has its own CW alarm & SNS topic connections
@omgitsbillryan omgitsbillryan added operations devops practice area categorization -- NOT a team assignment labels Jun 9, 2021
@jhouse-solvd jhouse-solvd changed the title Split PROD & STAGING build-error-check Canary into 2 Separate Canaries Monitoring - Split PROD & STAGING build-error-check Canary into 2 Separate Canaries Aug 13, 2021
@jhouse-solvd jhouse-solvd added the Awaiting Feedback this is for public websites team awaiting feedback from SMEs or other team members label Aug 20, 2021
@jhouse-solvd
Copy link
Contributor

@pjhill & @JoeTice -
This was just a suggestion based on where we left the canary when we shipped it to cover the base use cases that Dror was interested in.
Can you take a look at this and see if it would still be relevant to the work that y'all are doing around synthetics?

@jbritt1
Copy link
Contributor

jbritt1 commented Jun 23, 2022

@pjhill & @JoeTice, since synthetic-style monitoring has mostly gone to Datadog, I would feel this ticket to no longer be relevant or a priority. Could we close in your opinion(s)?

@jbritt1
Copy link
Contributor

jbritt1 commented Jul 13, 2022

Bumping for feedback. Also posted in channel: https://dsva.slack.com/archives/C01CHAY3ULR/p1657739962454579

@jbritt1 jbritt1 closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Feedback this is for public websites team awaiting feedback from SMEs or other team members devops practice area categorization -- NOT a team assignment operations
Projects
None yet
Development

No branches or pull requests

3 participants