Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Fix argocd-application.libsonnet jsonnet library #30036

Closed
2 of 4 tasks
mleclerc00 opened this issue Sep 16, 2021 · 2 comments
Closed
2 of 4 tasks

[Kubernetes] Fix argocd-application.libsonnet jsonnet library #30036

mleclerc00 opened this issue Sep 16, 2021 · 2 comments
Assignees
Labels
devops practice area categorization -- NOT a team assignment needs-grooming Use this to designate any issues that need grooming from the team operations

Comments

@mleclerc00
Copy link
Contributor

mleclerc00 commented Sep 16, 2021

Description

When deploying a new argocd application object it is built from the jsonnet template lib argocd-application.libsonnet. It offers two sync policies automatedDefault() (auto sync enabled) and automatedDisabled() (auto sync disabled). The problem being if you attempt to deploy a new app in a new namespace with the automatedDisabled() functionality the namespace will not be created and the deploy will fail.

This is due to the automatedDisabled() function not including the needed syncOptions (CreateNamespace=true) when defining a argocd application object.

argoproj/argo-cd#1809 (comment)
https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/blob/c628936ffc72a493cf7e6e0d965ad8045685c8e6/jsonnet/lib/argocd-application.libsonnet#L75-L103


Tasks

  • Add CreateNamespace=true to syncOptions for the automatedDisabled() function

Acceptance Criteria

  • Apps being deployed to a new namespace should create said namespace if it doesn't already exist if its using either automatedDisabled() or automatedDefault() policies

Reminders

  • Please attach your team label and any other appropriate label(s) (operations, devops, and needs-grooming will automatically be applied as part of the template)
  • Please connect to an epic (this will typically be done by the Platform Operations PM or TL)
@mleclerc00 mleclerc00 added operations devops practice area categorization -- NOT a team assignment needs-grooming Use this to designate any issues that need grooming from the team labels Sep 16, 2021
@mleclerc00 mleclerc00 self-assigned this Sep 16, 2021
@dginther
Copy link
Contributor

Closed, complete.

@mleclerc00
Copy link
Contributor Author

Confirmed that deploying new applications to a new namespace with the automatedDisabled() sync policy doesn't fail anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops practice area categorization -- NOT a team assignment needs-grooming Use this to designate any issues that need grooming from the team operations
Projects
None yet
Development

No branches or pull requests

2 participants