Removes create/update MHV accounts from CTA #23438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a review @department-of-veterans-affairs/vsa-public-websites-frontend @department-of-veterans-affairs/va-platform-cop-frontend |
3 similar comments
|
Can I get a review @department-of-veterans-affairs/vsa-public-websites-frontend @department-of-veterans-affairs/va-platform-cop-frontend |
|
Can I get a review @department-of-veterans-affairs/vsa-public-websites-frontend @department-of-veterans-affairs/va-platform-cop-frontend |
|
Can I get a review @department-of-veterans-affairs/vsa-public-websites-frontend @department-of-veterans-affairs/va-platform-cop-frontend |
jtmst
approved these changes
Mar 8, 2023
|
@department-of-veterans-affairs/va-platform-cop-frontend Can I get a review on this please? |
robertbylight
pushed a commit
that referenced
this pull request
Mar 20, 2023
* 52477: remove create/upgrade from actions, exportsFile, and MHV container * 52477: remove create/upgrade from profile reducer + unit tests
CBonade
pushed a commit
that referenced
this pull request
Mar 21, 2023
* 52477: remove create/upgrade from actions, exportsFile, and MHV container * 52477: remove create/upgrade from profile reducer + unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Summarize the changes that have been made to the platform)
This removes the ability to
createandupdateMHV accounts on VA.gov(What is the solution, why is this the solution)
The solution is to remove the
createMHVAccount,createAndUpgradeMHVAccount, andupgradeMHVAccountfrom theactions/mhv.jsfile primarily and remove anywhere where the actions + reducers + unit tests call it.(Which team do you work for, does your team own the maintenance of this component?)
Identity. No
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
No flipper is involved.
Related issue(s)
Link to ticket created in va.gov-team repo
Closes [FE] Remove MHV Accounts on vets-website va.gov-team#52477
Waiting on Remove Terms and Conditions #23442
Link to epic if not included in ticket
Identity - General Tech Debt va.gov-team#32749
Testing done
Describe what the old behavior was prior to the change
Old behavior is to create and/or upgrade MHV accounts. That functionality will be removed from vets-api which requires the necessary changes on vets-website
Describe the steps required to verify your changes are working as expected
Unit tests and E2E tests continue to work as expected.
Describe the tests completed and the results
Completed & passing
Screenshots
n/a
What areas of the site does it impact?
This should only impact VA.gov users who log in with a MHV account with no state.
Acceptance criteria
Requested Feedback
Ensure MHV accounts are neither created nor upgraded on the FE