From 3aeb9a31c096d283ba4a4cbccbff8b2365ed24c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Fri, 28 Apr 2023 19:49:46 +0200 Subject: [PATCH] Clarify comments on peer dependency error regexes (#7195) This should make it more clear that these lines are not part of the errors themselves. --- .../npm_and_yarn/update_checker/version_resolver.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb index 8687978c81d..90053872233 100644 --- a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb +++ b/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb @@ -26,7 +26,7 @@ class VersionResolver "vue" => %w(vue vue-template-compiler) }.freeze - # Error message from yarn add: + # Error message returned by `yarn add` (for Yarn classic): # " > @reach/router@1.2.1" has incorrect peer dependency "react@15.x || 16.x || 16.4.0-alpha.0911da3" # "workspace-aggregator- > test > react-dom@15.6.2" has incorrect peer dependency "react@^15.6.2" # " > react-burger-menu@1.9.9" has unmet peer dependency "react@>=0.14.0 <16.0.0" @@ -37,7 +37,7 @@ class VersionResolver "(?[^"]+)" /x - # Error message from yarn add: + # Error message returned by `yarn add` (for Yarn berry): # YN0060: │ eve-roster@workspace:. provides jest (p8d618) \ # with version 29.3.0, which doesn't satisfy \ # what ts-jest requests\n @@ -46,7 +46,7 @@ class VersionResolver YN0060:\s|\s.+\sprovides\s(?.+?)\s\((?\w+)\).+what\s(?.+?)\srequests /x - # Error message from npm install: + # Error message returned by `npm install` (for NPM 6): # react-dom@15.2.0 requires a peer of react@^15.2.0 \ # but none is installed. You must install peer dependencies yourself. NPM6_PEER_DEP_ERROR_REGEX = @@ -56,7 +56,7 @@ class VersionResolver (?.+?)\sbut\snone\sis\sinstalled. /x - # Error message from npm install: + # Error message returned by `npm install` (for NPM 8): # npm ERR! Could not resolve dependency: # npm ERR! peer react@"^16.14.0" from react-dom@16.14.0 #