Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take rust-version into account when updating lock file / manifest #5423

Open
epage opened this issue Jul 26, 2022 · 3 comments
Open

Take rust-version into account when updating lock file / manifest #5423

epage opened this issue Jul 26, 2022 · 3 comments
Labels
L: rust:cargo Rust crates via cargo T: feature-request Requests for new features versioning

Comments

@epage
Copy link

epage commented Jul 26, 2022

rust-version specifies what the minimum supported rust version is for the crate. In the ideal case, Dependabot would ensure that dependencies' rust-version is not higher than for the crate being modified.

@epage epage added the T: feature-request Requests for new features label Jul 26, 2022
@epage
Copy link
Author

epage commented Jul 26, 2022

In case its a blocker, the index does not yet have rust-version. We are looking to add it.

@jeffwidman
Copy link
Member

This makes sense to me, but I think this is all blocked on upstream?

We use native cargo to run the update, so I would expect it to flag when this is a problem, as long as we are correctly feeding it the manifest of the crate being updated so that it has access to that crate's rust-version field.

Once this gets added upstream, then should start showing up here as soon as we bump to the newer version of cargo.

@epage
Copy link
Author

epage commented Nov 30, 2023

MSRV is now in the index.

rust-lang/cargo#9930 is the issue for cargo update. However, whats not said is how Dependabot handles choosing breaking changes since you can't be relying on cargo update. Looks like Dependabot is using crates.io's API so that code would need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: rust:cargo Rust crates via cargo T: feature-request Requests for new features versioning
Projects
None yet
Development

No branches or pull requests

4 participants