Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commitlint: commit body lines must not be longer than 100 characters #5923

Closed
1 task done
MikeDombo opened this issue Oct 18, 2022 · 2 comments
Closed
1 task done
Labels
F: pull-requests Issues about Dependabot pull requests T: bug 🐞 Something isn't working

Comments

@MikeDombo
Copy link

MikeDombo commented Oct 18, 2022

Is there an existing issue for this?

#2445

  • I have searched the existing issues

Package ecosystem

maven

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

No response

Updated dependency

No response

What you expected to see, versus what you actually saw

Some dependabot commits cannot pass commitlint in CI due to the body's lines being over 100 characters.
Ex: aws-greengrass/aws-greengrass-logging-java#131

Error: You have commit messages with errors

⧗   input: chore(deps): bump maven-shade-plugin from 3.2.2 to 3.4.0

Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.2.2 to 3.4.0.
- [Release notes](https://github.com/apache/maven-shade-plugin/releases)
- [Commits](https://github.com/apache/maven-shade-plugin/compare/maven-shade-plugin-3.2.2...maven-shade-plugin-3.4.0)
✖   body's lines must not be longer than 100 characters [body-max-line-length]

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@MikeDombo MikeDombo added the T: bug 🐞 Something isn't working label Oct 18, 2022
@MikeDombo
Copy link
Author

#2445
This issue was closed in favor of #1666, but the PR which fixed #1666 does not fix this problem.

@deivid-rodriguez deivid-rodriguez added the F: pull-requests Issues about Dependabot pull requests label Oct 18, 2022
@jeffwidman
Copy link
Member

Thanks, you're right, so I re-opened #2445 as it has more context... and will close this as a dupe of the original. Thanks again for the pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: pull-requests Issues about Dependabot pull requests T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants