-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semver based ignoring / grouping doesn't work without package-lock.json #9685
Comments
dependency grouping based on semver doesnt does not work without package-lock.json. When there is a package-lock.json it works and shows current versions in the log. As dependabot worked without a package-lock.json in the past this is likely a regression. #9492 has another issue based on the missing package-lock.json. |
The first PR about this I have are on 2024-04-06. I run them weekly so whatever caused this regression was in the week before that. |
Is there an existing issue for this?
Package ecosystem
npm
Package manager version
10.5
Language version
18
Manifest location and content before the Dependabot update
/package.json
dependabot.yml content
Updated dependency
bump @types/node from 18.19.31 to 20.12.8
What you expected to see, versus what you actually saw
Versions within 18 can be updated but 19 or 20 are major updates that should have been ignored and were ignored in the past
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
EdJoPaTo/typescript-node-module-template#47
In the logs it looks like it knows not to update semver-major. Interestingly there are two spaces after the package name and I assume it should show the current version there so it might fail on that?
The PR knows the last version, so I'm not sure on that.
Smallest manifest that reproduces the issue
Untested but likely this:
The text was updated successfully, but these errors were encountered: