Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vue/compiler-sfc@3.x is a dependency and gets installed with Vue 2 projects #10

Open
JessicaSachs opened this issue Oct 17, 2024 · 2 comments

Comments

@JessicaSachs
Copy link

Hi! I was looking throughout a dependency graph of a Vue 2 + Vite project and noticed that the Vue 3 compiler chain was being included alongside the Vue 2 compiler chain, and npm was having issues properly de-duping the multiple conflicting dependencies.

I'm not quite sure why detective-vue2 has a dependency on the Vue 3+ compiler version.

It seems like this is best suited to be an optionalPeerDependency with a version range that includes 2.x and 3.x, not a real dependency

Could you fix the versioning?

@Havunen
Copy link
Collaborator

Havunen commented Oct 18, 2024

Hi,

Because vue3 compiler can parse dependencies from the vue2 and vue3 SFC templates. Its not optional dependency.
I am not aware of how we could require vue2 or vue3 version of the package. If I remember correctly they also had different API so the code would need some adjustments as well.

@Havunen
Copy link
Collaborator

Havunen commented Oct 19, 2024

The name is detective-vue2 because somebody else took detective-vue -name. Later this library was migrated to dependents -organisation and the name remained same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants