Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of features for next release (tentatively v0.3.0) #64

Open
deppen8 opened this issue Jun 23, 2019 · 3 comments
Open

Discussion of features for next release (tentatively v0.3.0) #64

deppen8 opened this issue Jun 23, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed new check New check for the linter

Comments

@deppen8
Copy link
Owner

deppen8 commented Jun 23, 2019

Creating this issue to propose and discuss additions that should be in the next release. Anything that seems like a winner will get added to the Milestone and we can work from there.

@deppen8 deppen8 added enhancement New feature or request help wanted Extra attention is needed new check New check for the linter labels Jun 23, 2019
@deppen8
Copy link
Owner Author

deppen8 commented Jun 23, 2019

I have done no research to see if this is possible, but it would be nice to be able to implement some checks that are "off" by default. This would allow for some more borderline stuff to be added. Bonus points if these could be grouped (e.g., "style", "syntax", "operations", etc) and turned on/off as groups.

An example of this came up today in the PuPPy Slack. It might be good to be able to turn on a "No df" check that discourages the use of generic df as a variable name.

@deppen8
Copy link
Owner Author

deppen8 commented Jul 11, 2019

On Twitter, Ted Petrou suggested "Slicing dataframes by row with df[:5] is pretty bad." Would be interesting to see if we can detect this versus other slicing behavior.

@deppen8
Copy link
Owner Author

deppen8 commented Aug 3, 2019

It might be good to be able to turn on a "No df" check that discourages the use of generic df as a variable name.

I've been working on this. Implementing it will require changing a bunch of our test cases because they violate it, but it should work. 🤣

I have done no research to see if this is possible, but it would be nice to be able to implement some checks that are "off" by default. This would allow for some more borderline stuff to be added. Bonus points if these could be grouped (e.g., "style", "syntax", "operations", etc) and turned on/off as groups.

I have done some research on this and it is possible. Will work on implementing this at the same time as the df check, so that it can be off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed new check New check for the linter
Projects
None yet
Development

No branches or pull requests

1 participant