Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Greeting 도메인 테스트 코드 작성 #458

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Conversation

its-sky
Copy link
Member

@its-sky its-sky commented Nov 8, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • Greeting 도메인 테스트 코드를 작성하였습니다.
  • 현재 테스트 커버리지 53%까지 향상되었습니다.

📝 참고사항

[GreetingController 테스트]
image

[GreetingService 테스트]
image

Copy link

github-actions bot commented Nov 8, 2024

Test Results

94 tests   94 ✅  2s ⏱️
24 suites   0 💤
24 files     0 ❌

Results for commit 66bb096.

Copy link
Member

@ywonchae1 ywonchae1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다 🙇🏻‍♀️ !!
저도 빨리 테코 짜야 하는데 .. TvT

import com.depromeet.greeting.port.out.AIPort;

public class FakeAIManager implements AIPort {
private static final String GENERATED_RESPONSE = "Hello, World!";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API 테스트에 페이크를 적절히 사용하신 것 배워 가겠습니다 !!! 멋진 코드

@its-sky its-sky merged commit dd09a93 into develop Nov 8, 2024
3 checks passed
@its-sky its-sky deleted the test/457-greeting branch November 8, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ Greeting 도메인 테스트 코드 작성
2 participants