-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webdriverjs): Recursively find <frame> #209
fix(webdriverjs): Recursively find <frame> #209
Conversation
Hi, @yokra9 do you mind providing tests for this fix. |
@michael-siek thanks for comment! added 2 commits for providing tests for this fix.
|
@yokra9 I just wanted to let you know we're still looking to see if we want this change added. As you pointed out, frames were deprecated years ago. Axe has never supported them. We're currently working to improve consistency between the various axe packages we maintain. That includes whether or not they support frames. If we add frame support to webdriverjs, we need to do it to webdriverio, puppeteer, cypress, Java/Ruby/C# selenium, Ruby Watir, etc. That is a fairly substantial amount of work. I very much do appreciate you setting up this PR. And I apologies for not noticing this before you made additional commits to it. I'm going to bring this up internally and will get back to you soon. |
Thank you very much for your contribution @yokra9. |
Fixed to recursively find
<frame>
and inject a script into them, not only<iframe>
.<frame>
is deprecated in HTML5, but sometimes use in bad examples when teach modern & accessible coding.ex: https://barrierfree.nict.go.jp/accessibility/whatsacs/sample/level0/index.html
Thanks!
Reviewer checks
Required fields, to be filled out by PR reviewer(s)