Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webdriverjs): Require new when instantiating #31

Merged
merged 3 commits into from
Jun 9, 2020
Merged

fix(webdriverjs): Require new when instantiating #31

merged 3 commits into from
Jun 9, 2020

Conversation

stephenmathieson
Copy link
Member

@stephenmathieson stephenmathieson commented Jun 9, 2020 •
edited by michael-siek
Loading

See https://github.com/dequelabs/html-team-proposals/pull/149.

BREAKING CHANGE: use new AxeBuilder(), not AxeBuilder()

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Code is reviewed for security

@stephenmathieson
fix(webdriverjs): Require new when instantiating
35482ab 
See dequelabs/axe-api-team#149.

BREAKING CHANGE: use `new AxeBuilder()`, not `AxeBuilder()`
@stephenmathieson stephenmathieson requested a review from a team June 9, 2020 14:13
michael-siek
michael-siek approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@michael-siek michael-siek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenmathieson stephenmathieson merged commit c0aa15c into develop Jun 9, 2020
@stephenmathieson stephenmathieson deleted the require-new-webdriverjs branch June 9, 2020 15:09
stephenmathieson added a commit that referenced this pull request Jun 9, 2020
@stephenmathieson
Merge branch 'develop' into webdriverjs-typescript
f54d1ee 
* develop:
  fix(cli): fix webdriver being passed from index.js (#33)
  fix(webdriverjs): Require `new` when instantiating (#31)
  style: Run prettier and fix lint warning (#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-siek michael-siek michael-siek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenmathieson @michael-siek