feat(wdio): Upgrade to support, and use types of v7 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Sep 14, 2021
| // Treat everything as Browser<'async'>: | ||
| // - Anything sync can also run async, since JS can await sync functions | ||
| // - Ignore MultiRemoteBrowser, which is just Browser with extra props | ||
| this.client = client as Browser<'async'>; |
There was a problem hiding this comment.
Needed to simplify this a little. Typescript does not like the union type .execute() here.
michael-siek
previously approved these changes
Sep 14, 2021
straker
previously requested changes
Sep 14, 2021
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
approved these changes
Sep 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for WDIO v7. This changes the types over to use v7's types. Using axe-core/webdriverio v4.3 with wdio v6 will now see
anyas the argument forclient.