fix(cli): pass chromedriver-path arg to webdriver #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not passing the
--chromedriver-path
arg value to webdriver.Within
webdriver.ts
config.chromedriverPath
would produce undefined even if--chromedriver-path
was set which would result in using the default chrome driver and not the one set by the user.If we add
chromedriverPath
to the destructured args and a user provides an invalid path we do error correctly throw the error as well as use the given Chrome driver:Invalid Path:
Valid Path:
Note:
--chromedriver-path
does not seem to support backwards compatibility in terms of Chrome Driver, it depends on your personal Chrome version. Example, if you're using V96 you cannot use V95 chrome driver, otherwise you will get a session error (as shown in the issue referenced).Closes issue: #370