Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): start webdriver correctly #69

Merged
merged 6 commits into from
Aug 17, 2020
Merged

fix(cli): start webdriver correctly #69

merged 6 commits into from
Aug 17, 2020

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Aug 14, 2020

See: #68

test: #72

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Code is reviewed for security

@michael-siek michael-siek requested a review from a team August 14, 2020 14:35
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow what's happening here. Can you explain why this fixes something?

packages/cli/lib/axe-test-urls.js Show resolved Hide resolved
@michael-siek michael-siek requested review from stephenmathieson and a team August 14, 2020 14:52
@michael-siek michael-siek merged commit 90675b4 into develop Aug 17, 2020
@michael-siek michael-siek deleted the fix-cli branch August 17, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants