fix(html-lang-valid): only run rule when attribute has value (#3663)

* Change html-lang-valid selector so the rule only applies when attrs have a value. Fix #3624 * add integration tests Co-authored-by: Steven Lambert <steven.lambert@deque.com>
dequelabs · Nov 29, 2022 · 1a7eecb · 1a7eecb
1 parent ac688c0
commit 1a7eecb
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 1 deletion.
diff --git a/lib/rules/html-lang-valid.json b/lib/rules/html-lang-valid.json
@@ -1,6 +1,6 @@
 {
   "id": "html-lang-valid",
-  "selector": "html[lang], html[xml\\:lang]",
+  "selector": "html[lang]:not([lang=\"\"]), html[xml\\:lang]:not([xml\\:lang=\"\"])",
   "tags": ["cat.language", "wcag2a", "wcag311", "ACT"],
   "actIds": ["bf051a"],
   "metadata": {

diff --git a/test/integration/full/html-lang-valid/frames/level1.html b/test/integration/full/html-lang-valid/frames/level1.html
@@ -10,5 +10,7 @@
     <iframe id="frame3" src="level2-a.html"></iframe>
     <iframe id="frame4" src="level2-b.html"></iframe>
     <iframe id="frame5" src="level2-c.html"></iframe>
+    <iframe id="frame6" src="level2-d.html"></iframe>
+    <iframe id="frame7" src="level2-e.html"></iframe>
   </body>
 </html>
diff --git a/test/integration/full/html-lang-valid/frames/level2-d.html b/test/integration/full/html-lang-valid/frames/level2-d.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html id="inapplicable2d" lang="">
+  <head>
+    <title>No lang test</title>
+    <meta charset="utf8" />
+    <script src="/axe.js"></script>
+  </head>
+  <body>
+    Empty lang
+  </body>
+</html>
diff --git a/test/integration/full/html-lang-valid/frames/level2-e.html b/test/integration/full/html-lang-valid/frames/level2-e.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html id="inapplicable2e" xml:lang="">
+  <head>
+    <title>No lang test</title>
+    <meta charset="utf8" />
+    <script src="/axe.js"></script>
+  </head>
+  <body>
+    Empty xml:lang
+  </body>
+</html>
diff --git a/test/integration/virtual-rules/html-lang-valid.js b/test/integration/virtual-rules/html-lang-valid.js
@@ -12,6 +12,21 @@ describe('html-lang-valid virtual-rule', function () {
     assert.lengthOf(results.incomplete, 0);
   });
 
+  it('is inapplicable with empty lang or xml:lang', function () {
+    // Error caught by html-has-lang instead
+    var results = axe.runVirtualRule('html-lang-valid', {
+      nodeName: 'html',
+      attributes: {
+        lang: ''
+      }
+    });
+
+    assert.lengthOf(results.inapplicable, 1);
+    assert.lengthOf(results.passes, 0);
+    assert.lengthOf(results.violations, 0);
+    assert.lengthOf(results.incomplete, 0);
+  });
+
   it('should pass with a valid lang', function () {
     var results = axe.runVirtualRule('html-lang-valid', {
       nodeName: 'html',