fix(image-redundant-alt): check for parent before calculating text (#…

…1705)
dequelabs · Jul 18, 2019 · 1adbd02 · 1adbd02
1 parent cc5bd59
commit 1adbd02
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/checks/label/duplicate-img-label.js b/lib/checks/label/duplicate-img-label.js
@@ -8,6 +8,11 @@ const parent = dom.findUpVirtual(
 	virtualNode,
 	'button, [role="button"], a[href], p, li, td, th'
 );
+
+if (!parent) {
+	return false;
+}
+
 const parentVNode = axe.utils.getNodeFromTree(parent);
 const visibleText = text.visibleVirtual(parentVNode, true).toLowerCase();
 if (visibleText === '') {

diff --git a/test/checks/label/duplicate-img-label.js b/test/checks/label/duplicate-img-label.js
@@ -105,6 +105,20 @@ describe('duplicate-img-label', function() {
 		);
 	});
 
+	it('should return false if img does not have required parent', function() {
+		fixture.innerHTML =
+			'<main><img id="target" alt="Plain text and more"><p>Plain text</p></main>';
+		var node = fixture.querySelector('#target');
+		axe.testUtils.flatTreeSetup(fixture);
+		assert.isFalse(
+			checks['duplicate-img-label'].evaluate(
+				node,
+				undefined,
+				axe.utils.getNodeFromTree(node)
+			)
+		);
+	});
+
 	(shadowSupport.v1 ? it : xit)(
 		'should return true if the img is part of a shadow tree',
 		function() {