fix: pass virtualNode to Rule.run

Closes #394
dequelabs · Jul 13, 2017 · 4534e86 · 4534e86
1 parent 3087e90
commit 4534e86
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/core/base/rule.js b/lib/core/base/rule.js
@@ -134,7 +134,7 @@ Rule.prototype.run = function (context, options, resolve, reject) {
 	try {
 		// Matches throws an error when it lacks support for document methods
 		nodes = this.gather(context)
-					.filter(node => this.matches(node.actualNode));
+					.filter(node => this.matches(node.actualNode, node));
 	} catch (error) {
 		// Exit the rule execution if matches fails
 		reject(new SupportError({cause: error, ruleId: this.id}));

diff --git a/test/core/base/rule.js b/test/core/base/rule.js
@@ -143,7 +143,26 @@ describe('Rule', function() {
 					assert.isTrue(success);
 					done();
 				}, isNotCalled);
+			});
+
+			it('should pass a virtualNode to #matches', function(done) {
+				var div = document.createElement('div');
+				fixture.appendChild(div);
+				var success = false,
+					rule = new Rule({
+						matches: function(node, virtualNode) {
+							assert.equal(virtualNode.actualNode, div);
+							success = true;
+							return [];
+						}
+					});
 
+				rule.run({
+					include: [axe.utils.getFlattenedTree(div)[0]]
+				}, {}, function() {
+					assert.isTrue(success);
+					done();
+				}, isNotCalled);
 			});
 
 			it('should handle an error in #matches', function(done) {