Skip to content

Commit

Permalink
fix(messages): Change messages from "page" to "document" where approp…
Browse files Browse the repository at this point in the history
…riate (#1156)

A minor fix that was missed in #983 

Closes issue: #983

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
  • Loading branch information
iamrafan authored and WilcoFiers committed Oct 4, 2018
1 parent 4279c72 commit 49dff2b
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions lib/checks/keyboard/page-has-main.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"metadata": {
"impact": "moderate",
"messages": {
"pass": "Page has at least one main landmark",
"fail": "Page does not have a main landmark"
"pass": "Document has at least one main landmark",
"fail": "Document does not have a main landmark"
}
}
}
14 changes: 7 additions & 7 deletions lib/checks/keyboard/page-no-duplicate-banner.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"id": "page-no-duplicate-banner",
"evaluate": "page-no-duplicate.js",
"options": {
"selector": "header:not([role]), [role=banner]",
"nativeScopeFilter": "article, aside, main, nav, section"
},
"options": {
"selector": "header:not([role]), [role=banner]",
"nativeScopeFilter": "article, aside, main, nav, section"
},
"metadata": {
"impact": "moderate",
"messages": {
"pass": "Document has no more than one banner landmark",
"fail": "Document has more than one banner landmark"
"pass": "Document does not have more than one banner landmark",
"fail": "Document has more than one banner landmark"
}
}
}
}
4 changes: 2 additions & 2 deletions lib/checks/keyboard/page-no-duplicate-contentinfo.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"metadata": {
"impact": "moderate",
"messages": {
"pass": "Page does not have more than one contentinfo landmark",
"fail": "Page has more than one contentinfo landmark"
"pass": "Document does not have more than one contentinfo landmark",
"fail": "Document has more than one contentinfo landmark"
}
}
}
4 changes: 2 additions & 2 deletions lib/checks/keyboard/page-no-duplicate-main.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"metadata": {
"impact": "moderate",
"messages": {
"pass": "Page does not have more than one main landmark",
"fail": "Page has more than one main landmark"
"pass": "Document does not have more than one main landmark",
"fail": "Document has more than one main landmark"
}
}
}
4 changes: 2 additions & 2 deletions lib/rules/landmark-no-duplicate-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"best-practice"
],
"metadata": {
"description": "Ensures the page has at most one banner landmark",
"help": "Page must not have more than one banner landmark"
"description": "Ensures the document has at most one banner landmark",
"help": "Document must not have more than one banner landmark"
},
"all": [],
"any": [
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/landmark-no-duplicate-contentinfo.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"best-practice"
],
"metadata": {
"description": "Ensures the page has at most one contentinfo landmark",
"help": "Page must not have more than one contentinfo landmark"
"description": "Ensures the document has at most one contentinfo landmark",
"help": "Document must not have more than one contentinfo landmark"
},
"all": [],
"any": [
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/landmark-one-main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"best-practice"
],
"metadata": {
"description": "Ensures the page has only one main landmark and each iframe in the page has at most one main landmark",
"help": "Page must have one main landmark"
"description": "Ensures the document has only one main landmark and each iframe in the page has at most one main landmark",
"help": "Document must have one main landmark"
},
"all": [
"page-has-main",
Expand Down

0 comments on commit 49dff2b

Please sign in to comment.