fix: use virtualNode in title-only check

Closes #388
dequelabs · Jun 30, 2017 · 5fb06e3 · 5fb06e3
1 parent dbbc544
commit 5fb06e3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/checks/label/title-only.js b/lib/checks/label/title-only.js
@@ -1,2 +1,2 @@
-var labelText = axe.commons.text.label(node);
+var labelText = axe.commons.text.label(virtualNode);
 return !labelText && !!(node.getAttribute('title') || node.getAttribute('aria-describedby'));
diff --git a/test/checks/label/title-only.js b/test/checks/label/title-only.js
@@ -5,6 +5,7 @@ describe('title-only', function () {
 
 	afterEach(function () {
 		fixture.innerHTML = '';
+		axe._tree = undefined;
 	});
 
 	it('should return true if an element only has a title', function () {
@@ -14,9 +15,11 @@ describe('title-only', function () {
 
 		fixture.appendChild(node);
 
-		assert.isTrue(checks['title-only'].evaluate(node));
+		var tree = axe._tree = axe.utils.getFlattenedTree(fixture);
+
+		assert.isTrue(checks['title-only'].evaluate(node, undefined, axe.utils.getNodeFromTree(tree[0], node)));
 		node.setAttribute('aria-label', 'woop');
-		assert.isFalse(checks['title-only'].evaluate(node));
+		assert.isFalse(checks['title-only'].evaluate(node, undefined, axe.utils.getNodeFromTree(tree[0], node)));
 	});
 
 	it('should return true if an element only has aria-describedby', function () {
@@ -30,9 +33,11 @@ describe('title-only', function () {
 		fixture.appendChild(node);
 		fixture.appendChild(dby);
 
-		assert.isTrue(checks['title-only'].evaluate(node));
+		var tree = axe._tree = axe.utils.getFlattenedTree(fixture);
+
+		assert.isTrue(checks['title-only'].evaluate(node, undefined, axe.utils.getNodeFromTree(tree[0], node)));
 		node.setAttribute('aria-label', 'woop');
-		assert.isFalse(checks['title-only'].evaluate(node));
+		assert.isFalse(checks['title-only'].evaluate(node, undefined, axe.utils.getNodeFromTree(tree[0], node)));
 	});
 
 });