fix: add <search> element semantics (#4115)

dequelabs · Aug 1, 2023 · 637bf6c · 637bf6c
1 parent c4c3e65
commit 637bf6c
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 2 deletions.
diff --git a/lib/commons/standards/implicit-html-roles.js b/lib/commons/standards/implicit-html-roles.js
@@ -157,6 +157,7 @@ const implicitHtmlRoles = {
   option: 'option',
   output: 'status',
   progress: 'progressbar',
+  search: 'search',
   section: vNode => {
     return hasAccessibleName(vNode) ? 'region' : null;
   },

diff --git a/lib/standards/html-elms.js b/lib/standards/html-elms.js
@@ -749,6 +749,10 @@ const htmlElms = {
     allowedRoles: false,
     noAriaAttrs: true
   },
+  search: {
+    contentTypes: ['flow'],
+    allowedRoles: ['form', 'group', 'none', 'presentation', 'region', 'search']
+  },
   section: {
     contentTypes: ['sectioning', 'flow'],
     allowedRoles: [

diff --git a/test/integration/rules/aria-allowed-attr/passes.html b/test/integration/rules/aria-allowed-attr/passes.html
@@ -2156,3 +2156,5 @@
 
 <input type="checkbox" aria-checked="false" id="pass98" />
 <input type="checkbox" aria-checked="mixed" id="pass99" />
+
+<search aria-expanded="true" id="pass100"></search>
diff --git a/test/integration/rules/aria-allowed-attr/passes.json b/test/integration/rules/aria-allowed-attr/passes.json
@@ -101,6 +101,7 @@
     ["#pass96"],
     ["#pass97"],
     ["#pass98"],
-    ["#pass99"]
+    ["#pass99"],
+    ["#pass100"]
   ]
 }
diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.html b/test/integration/rules/aria-allowed-role/aria-allowed-role.html
@@ -301,3 +301,5 @@ <h1 role="text" id="fail-text-1">ok</h1>
   />
   <area shape="circle" coords="15,15,10" role="checkbox" id="fail-imgmap-2" />
 </map>
+
+<search role="form" id="pass-search-elm"></search>
diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.json b/test/integration/rules/aria-allowed-role/aria-allowed-role.json
@@ -87,7 +87,8 @@
     ["#pass-imgmap-1"],
     ["#pass-imgmap-2"],
     ["#pass-navnone-1"],
-    ["#pass-navnone-2"]
+    ["#pass-navnone-2"],
+    ["#pass-search-elm"]
   ],
   "violations": [
     ["#fail-dd-no-role"],