Skip to content

Commit

Permalink
feat(aria-role): Remove non-existing "text" role (#1069)
Browse files Browse the repository at this point in the history
  • Loading branch information
WilcoFiers authored Aug 22, 2018
1 parent f4f6df6 commit 67ec1f5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
7 changes: 0 additions & 7 deletions lib/commons/aria/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1901,13 +1901,6 @@ lookupTable.role = {
implicit: ['dt'],
unsupported: false
},
text: {
type: 'structure',
owned: null,
nameFrom: ['author', 'contents'],
context: null,
unsupported: false
},
textbox: {
type: 'widget',
attributes: {
Expand Down
4 changes: 2 additions & 2 deletions test/integration/rules/aria-roles/aria-roles.html
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
<div role="none" id="pass65">ok</div>
<div role="cell" id="pass66">ok</div>
<div role="searchbox" id="pass67">ok</div>
<div role="text" id="pass68">ok</div>
<div role="table" id="pass69">ok</div>
<div role="doc-abstract" id="pass70">ok</div>
<div role="doc-acknowledgments" id="pass71">ok</div>
Expand Down Expand Up @@ -125,6 +124,7 @@
<div role="window" id="fail12">fail</div>
<!-- invalid roles -->
<div role="lol" id="fail13">fail</div>
<div role="text" id="fail14">ok</div>
<!-- unsupported roles -->
<div role="figure" id="fail14">fail</div>
<div role="figure" id="fail15">fail</div>
</div>
5 changes: 3 additions & 2 deletions test/integration/rules/aria-roles/aria-roles.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"rule": "aria-roles",
"violations": [
["#fail1"], ["#fail2"], ["#fail3"], ["#fail4"], ["#fail5"], ["#fail6"], ["#fail7"],
["#fail8"], ["#fail9"], ["#fail10"], ["#fail11"], ["#fail12"], ["#fail13"], ["#fail14"]
["#fail8"], ["#fail9"], ["#fail10"], ["#fail11"], ["#fail12"], ["#fail13"], ["#fail14"],
["#fail15"]
],
"passes": [
["#pass1"], ["#pass2"], ["#pass3"], ["#pass4"], ["#pass5"], ["#pass6"], ["#pass7"],
Expand All @@ -15,7 +16,7 @@
["#pass43"], ["#pass44"], ["#pass45"], ["#pass46"], ["#pass47"], ["#pass48"], ["#pass49"],
["#pass50"], ["#pass51"], ["#pass52"], ["#pass53"], ["#pass54"], ["#pass55"], ["#pass56"],
["#pass57"], ["#pass58"], ["#pass59"], ["#pass60"], ["#pass61"], ["#pass62"], ["#pass63"],
["#pass64"], ["#pass65"], ["#pass66"], ["#pass67"], ["#pass68"], ["#pass69"], ["#pass70"],
["#pass64"], ["#pass65"], ["#pass66"], ["#pass67"], ["#pass69"], ["#pass70"],
["#pass71"], ["#pass72"], ["#pass73"], ["#pass74"], ["#pass75"], ["#pass76"], ["#pass77"],
["#pass78"], ["#pass79"], ["#pass80"], ["#pass81"], ["#pass82"], ["#pass83"], ["#pass84"],
["#pass85"], ["#pass86"], ["#pass87"], ["#pass88"], ["#pass89"], ["#pass90"], ["#pass91"],
Expand Down

0 comments on commit 67ec1f5

Please sign in to comment.