Skip to content

Commit

Permalink
Merge branch 'develop' into text-updates
Browse files Browse the repository at this point in the history
  • Loading branch information
marktnoonan committed Jun 14, 2024
2 parents 2e025e5 + 3ef9353 commit c98fc7c
Show file tree
Hide file tree
Showing 14 changed files with 710 additions and 46 deletions.
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,14 @@ jobs:
paths:
- node_modules

# Build and cache axe.js
# Build and cache built files
build_unix:
<<: *defaults
<<: *unix_box
steps:
- checkout
- <<: *restore_dependency_cache_unix
- run: npm run prepare
- run: npm run build
- save_cache:
key: v9-cache-build-<< pipeline.git.revision >>
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
node-version: 20
cache: 'npm'
- run: npm ci
- run: npm run prepare
- run: npm run build
- uses: actions/upload-artifact@v4
with:
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,3 @@ typings/axe-core/axe-core-tests.js

# doc
doc/rule-descriptions.*.md

1 change: 1 addition & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ module.exports = [
ignores: [
'**/node_modules/*',
'**/tmp/*',
'patches/*',
'build/tasks/aria-supported.js',
'doc/api/*',
'doc/examples/jest_react/*.js',
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/data-table-large-matches.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { isDataTable, toArray } from '../commons/table';

function dataTableLargeMatches(node) {
if (isDataTable(node)) {
var tableArray = toArray(node);
const tableArray = toArray(node);
return (
tableArray.length >= 3 &&
tableArray[0].length >= 3 &&
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/frame-title-has-text-matches.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { sanitize } from '../commons/text';

function frameTitleHasTextMatches(node) {
var title = node.getAttribute('title');
const title = node.getAttribute('title');
return !!sanitize(title);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/rules/label-matches.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function labelMatches(node, virtualNode) {
return true;
}

var type = virtualNode.attr('type').toLowerCase();
const type = virtualNode.attr('type').toLowerCase();
return (
['hidden', 'image', 'button', 'submit', 'reset'].includes(type) === false
);
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/link-in-text-block-matches.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { sanitize } from '../commons/text';
import { isVisibleOnScreen, isInTextBlock } from '../commons/dom';

function linkInTextBlockMatches(node) {
var text = sanitize(node.innerText);
var role = node.getAttribute('role');
const text = sanitize(node.innerText);
const role = node.getAttribute('role');

if (role && role !== 'link') {
return false;
Expand Down
Loading

0 comments on commit c98fc7c

Please sign in to comment.