perf: cache selector creation

dequelabs · Jun 12, 2024 · cb5c331 · cb5c331
1 parent 2481379
commit cb5c331
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/lib/core/utils/dq-element.js b/lib/core/utils/dq-element.js
@@ -96,23 +96,32 @@ DqElement.prototype = {
    * @return {String}
    */
   get selector() {
-    return this.spec.selector || [getSelector(this.element, this._options)];
+    if (!this.spec.selector) {
+      this.spec.selector = [getSelector(this.element, this._options)];
+    }
+    return this.spec.selector;
   },
 
   /**
    * A unique CSS selector for the element, including its ancestors down to the root node
    * @return {String}
    */
   get ancestry() {
-    return this.spec.ancestry || [getAncestry(this.element)];
+    if (!this.spec.ancestry) {
+      this.spec.ancestry = [getAncestry(this.element)];
+    }
+    return this.spec.ancestry;
   },
 
   /**
    * Xpath to the element
    * @return {String}
    */
   get xpath() {
-    return this.spec.xpath || [getXpath(this.element)];
+    if (!this.spec.xpath) {
+      this.spec.xpath = [getXpath(this.element)];
+    }
+    return this.spec.xpath;
   },
 
   /**