fix: Don't crash with slot elements without shadowDOM (#977)

* fix: Don't crash with slot elements without shadowDOM * test: Test flattenedTree with slot for non-shadowDOM
dequelabs · Jun 28, 2018 · cc044af · cc044af
1 parent db3ed40
commit cc044af
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/core/utils/flattened-tree.js b/lib/core/utils/flattened-tree.js
@@ -89,7 +89,7 @@ axe.utils.getFlattenedTree = function (node, shadowId) {
 		if (nodeName === 'content') {
 			realArray = Array.from(node.getDistributedNodes());
 			return realArray.reduce(reduceShadowDOM, []);
-		} else if (nodeName === 'slot') {
+		} else if (nodeName === 'slot' && typeof node.assignedNodes === 'function') {
 			realArray = Array.from(node.assignedNodes());
 			if (!realArray.length) {
 				// fallback content

diff --git a/test/core/utils/flattened-tree.js b/test/core/utils/flattened-tree.js
@@ -231,6 +231,13 @@ describe('axe.utils.getFlattenedTree', function() {
 				assert.equal(virtualDOM[0].actualNode, vNode.actualNode);
 			});
 		});
+	} else {
+		it('does not throw when slot elements are used', function () {
+			fixture.innerHTML = '<button><slot></slot></button>';
+			assert.doesNotThrow(function () {
+				axe.utils.getFlattenedTree(fixture);
+			});
+		});
 	}
 
 	if (shadowSupport.undefined) {