Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No banner comments in axe.min.js (PR #1112) #1108

Closed
jeeyyy opened this issue Aug 28, 2018 · 1 comment
Closed

No banner comments in axe.min.js (PR #1112) #1108

jeeyyy opened this issue Aug 28, 2018 · 1 comment
Assignees
Labels
fix Bug fixes

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Aug 28, 2018

Some time between releases 3.0.2 and 3.1.1 the banner comments on axe.js and axe.min.js have been lost.

/*! aXe v3.0.2
 * Copyright (c) 2018 Deque Systems, Inc.
 *
 * Your use of this Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 *
 * This entire copyright notice must appear in every copy of this file you
 * distribute or in any file that contains substantial portions of this source
 * code.
 */

This caused rspec and cucumber in axe-matchers and attest-ruby tests which rely on jslib injection to fail.

expect(page).to have_received(:execute_script).with(a_string_starting_with ("/*! aXe"))

its(:jslib) { is_expected.to start_with("/*! aXe") }

Analysis:
v3.0.2 - Has banner comments.
v3.0.3 - Neither files have banner comments.
v3.1.1 - axe.min.js is missing the banner comments.

@jeeyyy jeeyyy self-assigned this Aug 28, 2018
@jeeyyy jeeyyy added the fix Bug fixes label Aug 28, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Aug 28, 2018

I have worked around the test cases to verify other strings in those respective ruby test cases, so no immediate work is necessary for this.

@jeeyyy jeeyyy changed the title Lost banner comments on generated axe.min.js Lost banner comments on generated axe.min.js (PR #1112) Aug 29, 2018
@jeeyyy jeeyyy changed the title Lost banner comments on generated axe.min.js (PR #1112) No banner comments in axe.min.js (PR #1112) Aug 29, 2018
@jeeyyy jeeyyy closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant