Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axe.utils.getNodeFromTree
currently doesn't return early if it has found a result. It continues iterating through the rest of the children. But the perf win is pretty huge: ~600ms on the page I'm testing.To test I ran axe against this URL like this:
And then I looked at the
Measure runchecks_color-contrast took XXXX ms
line. (As that rule uses this method quite a lot).numbers:
develop
On average, a 620ms improvement in this one rule.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)