fix: Prevent error when using <select name="attributes"> #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
previously requested changes
Mar 21, 2019
administratort
previously approved these changes
Mar 21, 2019
|
我也不知道怎么来评论这个项目！ |
WilcoFiers
previously requested changes
Mar 28, 2019
straker
dismissed
WilcoFiers’s stale review
Resolved. We couldn't move to axe.commons.dom since a util function getSelector relies on the function, and core can't access commons functions
WilcoFiers
approved these changes
Mar 28, 2019
WilcoFiers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time we access
node.attributeswe should check that it returns aNameNodeMapas expected and that the DOM isn't clobbered.Closes: #1397
Reviewer checks
Required fields, to be filled out by PR reviewer(s)