Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: impact property of Result and NodeResult should be optional #1476

Closed
dbjorge opened this issue Apr 4, 2019 · 0 comments
Closed

Comments

@dbjorge
Copy link
Contributor

dbjorge commented Apr 4, 2019

Expectation: https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#result-arrays documents that impact can be null in for results or nodes that correspond to passing results; the corresponding impact properties in axe.d.ts of the Result and NodeResults types should accept null values, accordingly.

Actual: axe.d.ts specifies those impact properties as non-optional

Motivation: We see type-checking errors in our consuming project.


axe-core version: 3.2.2
axe-webdriver, extension or other integration version: n/a

Browser and Assistive Technology versions

For Tooling issues:
- Node version: current LTS (10.15.3)
- Typescript version: current stable (3.4.1)
- Platform:  n/a (Windows)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant