Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Lighthouse Error: Document doesn't have a <title> element #1497

Closed
NithinGCC opened this issue Apr 15, 2019 · 7 comments
Closed

False Lighthouse Error: Document doesn't have a <title> element #1497

NithinGCC opened this issue Apr 15, 2019 · 7 comments

Comments

@NithinGCC
Copy link

NithinGCC commented Apr 15, 2019

Hi,
For one of our pages https://www.blinds.com/p/blindscom-2-deluxe-wood-blind/503440 we are seeing that the lighthouse is having issues with accessibility and SEO.
image

"Document doesn't have a <title> element" error is shown but we do have the title tag in the DOM. Also, other SEO tools are seeing the page and tags properly.
I read in some other threads about a possible Lighthouse-axe integration issue. I ran axe extension audit and I got this
image

Would you be able to help me here please?

Thanks,
Nithin

@patrickhulce
Copy link

patrickhulce commented Apr 15, 2019

To add a little more info here, Lighthouse fails because axe takes ~2 minutes to complete and our deadline is 60 seconds.

Most of this time seems to be spent in findDomNode

image

Downstream issue is GoogleChrome/lighthouse#8287

@straker
Copy link
Contributor

straker commented Apr 16, 2019

Thanks for the issue. isAccessibleRef has been a performance bottleneck and contributes to some of the slow rules that cause axe to take so long to complete. I've been looking at axe's performance over the past couple of weeks and hopefully will be able to start making great improvements for large pages.

@straker
Copy link
Contributor

straker commented Apr 18, 2019

@patrickhulce Could you elaborate more on the 60s deadline for Lighthouse? Is that 60s for the entire run (including axe) or for each individual aspect Lighthouse tests (perf, a11y, etc.)? Do you have pages you run your benchmarks against that we could maybe test against as well?

@patrickhulce
Copy link

It's 60 seconds for each "gatherer" which is for each script we run on the page. Axe is one such script and so if axe does not complete within 60 seconds, all accessibility audits will display an error in the report.

We don't have the extremely large sites that axe typically fails on in our regular test suite (most of those come from end-user reports), but GoogleChrome/lighthouse#2293 is an older issue that tracked a set of sites that were particularly slow. A few of those might still be good axe candidates? It's tricky because in many cases what slows axe down also slows the page itself down and so it tends to get fixed by the site owner at some point :)

@molant
Copy link

molant commented Apr 18, 2019

One of my to-go sites to stress tools is www.tmz.com. Might be worth giving it a try.

@straker
Copy link
Contributor

straker commented Apr 18, 2019

Thanks for the information. I'll take a look at the sites.

@straker
Copy link
Contributor

straker commented May 8, 2019

I'm going to close this issue for now. With the latest perf changes, axe runs in under 10s on the given page. I'll continue to work on improving axe's performance.

@straker straker closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants