Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): split button name rule into button only and button input rules #1615

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

scurker
Copy link
Member

@scurker scurker commented Jun 5, 2019

Split button-name into button-name and input-button-name rules.

  • button-name rule should only include button and [role=button]
  • input-button-name rule should only include inputs where type is button, reset, or submit.

For each rule, removed any checks that were no longer applicable to the targeted elements.

Closes: #1326

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@scurker scurker requested a review from a team as a code owner June 5, 2019 19:14
@scurker scurker requested a review from a team June 5, 2019 19:14
@straker
Copy link
Contributor

straker commented Jun 5, 2019

LGTM but will need @WilcoFiers approval before we merge

Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacking context, but the code LGTM aside from a whitespace thing.

lib/rules/input-button-name.json Show resolved Hide resolved
lib/rules/input-button-name.json Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers added this to the Axe-core 3.3 milestone Jun 6, 2019
@straker straker removed this from the Axe-core 3.3 milestone Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button-name rule gives incorrect advise for button elements
4 participants