test: require new release rule help docs to be active before creating release #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously requested changes
Jul 11, 2019
test/test-rule-help-version.js
Outdated
| var assert = require('assert'); | ||
| var packageJSON = require(path.join(__dirname, '../package.json')); | ||
|
|
||
| var version = packageJSON.version.substr( |
There was a problem hiding this comment.
This looks a little more complicated and error-prone than necessary. What about:
var [major,minor] = packageJSON.version.split('.')
var url = `https://dequeuniversity.com/rules/axe/${major}.${minor}`
// ...There was a problem hiding this comment.
Also, since this test is run in a Node.js context, we can use "modern" JS syntax. We don't have PhantomJS getting in the way here.
There was a problem hiding this comment.
Except that our eslint blocks all es6 syntax in the test dir.
stephenmathieson
previously approved these changes
Jul 11, 2019
WilcoFiers
previously approved these changes
Jul 12, 2019
WilcoFiers
changed the title
straker
dismissed stale reviews from WilcoFiers and stephenmathieson
via
92851fc
jeeyyy
approved these changes
Jul 15, 2019
Per #1700 (comment), we'd need to update ESLint to allow for it. |
stephenmathieson
approved these changes
Jul 15, 2019
WilcoFiers
pushed a commit
that referenced
this pull request
Jul 22, 2019
… release (#1700) * tests: require new release rule help docs to be active before creating release * use underscores * update comment * update comment * use split * add test_rule_help_version to workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should block a release pr (a pr into
masterbranch only) if the newest axe version rule help docs are not active.Reviewer checks
Required fields, to be filled out by PR reviewer(s)