fix(aria-required-children): allow combobox to own a searchbox

[straker]

Allow aria-required-children to pass when the role=combobx owns a native input[type=search]

Linked issue: #1688

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

• Follows the commit message policy, appropriate for next version
• Has documentation updated, a DU ticket, or requires no documentation change
• Includes new tests, or was unnecessary
• Code is reviewed for security by: @dylanb

Added role inheritance

[dylanb]

@straker Have we checked #1688 for accessibility supported?

Resolved

Resolved

[WilcoFiers]

I'm really sorry to do this. Recent discussions happening in ACT-R and ARIA WG have taught me that we shouldn't allow inheritance at all. The ARIA spec doesn't allow searchbox inside of combobox. This is probably an oversight in the spec, same as how directory should have had listitem as a required owned element, and listitem should have directory as a required context role.

There's a discussion happening about it here:
w3c/aria#1030

For axe-core, I think you should patch our mapping and ditch the getRoleInheritance method. Again, sorry for the wasted effort. :(

[straker]

Does that mean reverting to the first commit cb3fbab?

Resolved

[WilcoFiers]

I found two issues while reviewing this. We're not quite done with the combobox yet. But this resolves the issue raised.