-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria-required-children): allow combobox to own a searchbox #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry to do this. Recent discussions happening in ACT-R and ARIA WG have taught me that we shouldn't allow inheritance at all. The ARIA spec doesn't allow searchbox
inside of combobox
. This is probably an oversight in the spec, same as how directory
should have had listitem
as a required owned element, and listitem
should have directory
as a required context role.
There's a discussion happening about it here:
w3c/aria#1030
For axe-core, I think you should patch our mapping and ditch the getRoleInheritance
method. Again, sorry for the wasted effort. :(
Does that mean reverting to the first commit cb3fbab? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two issues while reviewing this. We're not quite done with the combobox yet. But this resolves the issue raised.
Allow
aria-required-children
to pass when therole=combobx
owns a nativeinput[type=search]
Linked issue: #1688
Reviewer checks
Required fields, to be filled out by PR reviewer(s)