Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast-matches): don't check aria-disabled explicit label element #1741

Merged
merged 2 commits into from
Aug 14, 2019
Merged

fix(color-contrast-matches): don't check aria-disabled explicit label element #1741

merged 2 commits into from
Aug 14, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 31, 2019 •
edited
Loading

We check if the node or its parent is aria-disabled, but not the element an explicit label pointed to. Went ahead and updated the code to use es6.

Closes issue: #1731

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 31, 2019 17:31
@straker straker merged commit 5bb566f into develop Aug 14, 2019
@straker straker deleted the fixColorContrastDisabled branch August 14, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers