fix(scrollable-region-focus): ignore scrollable regions without content #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
previously requested changes
Aug 28, 2019
WilcoFiers
approved these changes
Aug 28, 2019
| @@ -41,7 +41,7 @@ describe('dom.hasContentVirtual', function() { | |||
| it('is false if the element has an aria label but `ignoreAria=true`', function() { | |||
| fixture.innerHTML = '<div id="target" aria-label="my-label"> </div>'; | |||
| tree = axe.utils.getFlattenedTree(fixture); | |||
| assert.isTrue( | |||
| assert.isFalse( | |||
There was a problem hiding this comment.
Yikes... That was probably me.
straker
changed the title
straker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasContentVirtualwould always run the aria label check even when theignoreAriaflag was set totrue, it also resulted in the entire check always returningtrue.The test wanted false but was asserting
true.Closes issue: #1701 (will now properly ignore the scrollable region that doesn't have content)
Reviewer checks
Required fields, to be filled out by PR reviewer(s)