Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color contrast nonMbp charset isn't global and isn't sanitised #1993

Closed
WilcoFiers opened this issue Jan 22, 2020 · 5 comments
Closed

color contrast nonMbp charset isn't global and isn't sanitised #1993

WilcoFiers opened this issue Jan 22, 2020 · 5 comments
Assignees
Labels
color contrast Color contrast issues fix Bug fixes rules Issue or false result from an axe-core rule
Milestone

Comments

@WilcoFiers
Copy link
Contributor

If I pass something like this into the color contrast rule, it is tested because only the first char is stripped out, and the spaces aren't removed:

<div style="color: #ccc">
  &#x20A0;
  &#x20A1;
  &#x20A2;
  &#x20A3;
</div>

Expected: This element is incomplete for color-contrast
Actual: This element fails color-contrast

@WilcoFiers WilcoFiers added color contrast Color contrast issues fix Bug fixes rules Issue or false result from an axe-core rule labels Jan 22, 2020
@WilcoFiers WilcoFiers added this to the Axe-core 3.5 milestone Jan 22, 2020
@straker straker self-assigned this Jan 30, 2020
@jeankaplansky
Copy link
Contributor

jeankaplansky commented Feb 4, 2020

Added to release notes 2/04/2020;

@padmavemulapati
Copy link

non BMP chanrecter color-contrast test still seeing voilations, not needs review.

@straker
Copy link
Contributor

straker commented Feb 7, 2020

Confirmed. The check options are not be passed in due to a misconfiguration of the check.json.

@straker
Copy link
Contributor

straker commented Feb 10, 2020

@padmavemulapati Should be fixed now in the latest axe-core

@padmavemulapati
Copy link

padmavemulapati commented Feb 12, 2020

will verify the same with axe and attest extensions once axe-core3.5 deployed in devTools.
For now verified with axe-coconut(3.5.0.) , seeing "incomplete" results.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color contrast Color contrast issues fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

4 participants