Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(has-lang): update message to indicate that xml:lang is not valid on HTML pages #2093

Merged
merged 2 commits into from
Mar 12, 2020
Merged

fix(has-lang): update message to indicate that xml:lang is not valid on HTML pages #2093

merged 2 commits into from
Mar 12, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Mar 11, 2020 •
edited by WilcoFiers
Loading

When xml:lang attribute is present but no lang attribute, it's a bit confusing to say "The element does not have a lang attribute"

Closes issue: #2080

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner March 11, 2020 21:38
@straker straker merged commit c3a7de2 into develop Mar 12, 2020
@straker straker deleted the xmlLang branch March 12, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers