Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-describedby referenced to empty element is not shown as "needs review" #2149

Closed
iamrafan opened this issue Apr 7, 2020 · 3 comments
Closed
Labels
info needed More information or research is needed to continue

Comments

@iamrafan
Copy link
Contributor

iamrafan commented Apr 7, 2020

The intended fix for issue #1151 is not working as expected. Case-1 in the below examples does not show up as "needs review'.

Demo: https://codepen.io/iamrafan/pen/abOrzVb?editors=1000

aria-describedby referenced to an empty <span> is now not a failure but it does not show up as 'needs review' as well.

axe-core version: 3.5.2-canary.37be85f
axe-Coconut version: 4.4.1
@straker
Copy link
Contributor

straker commented Apr 13, 2020

The code is working as expected from that issue. The original issue was that axe errored when the element was missing but has always passed if the element exists (even when empty). So the change allows non-existent elements to not fail.

Are you saying you'd like axe-core to flag empty aria-describedby elements as needs review?

@straker straker added the info needed More information or research is needed to continue label Apr 13, 2020
@iamrafan
Copy link
Contributor Author

@straker Thanks for the clarification.

Are you saying you'd like axe-core to flag empty aria-describedby elements as needs review?

I am good either way

@straker
Copy link
Contributor

straker commented Sep 4, 2020

Closing as the code snippet provided shows needs review for the missing aria-describedby:

"Fix all of the following:
ARIA attribute element ID does not exist on the page: aria-describedby="giftCard_2Error_2""

@straker straker closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info needed More information or research is needed to continue
Projects
None yet
Development

No branches or pull requests

2 participants