Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure check options is always an object #2191

Closed
WilcoFiers opened this issue Apr 28, 2020 · 2 comments
Closed

Ensure check options is always an object #2191

WilcoFiers opened this issue Apr 28, 2020 · 2 comments
Assignees
Labels
core Issues in the core code (lib/core) feat New feature or enhancement
Milestone

Comments

@WilcoFiers
Copy link
Contributor

Currently check options can be any type. Axe-core currently has arrays and objects here. It would be better if all of these were objects, making the API more predictable and easier to document.

We'll have to make this backward compatible though, so that if someone passes an array as an option, checks that support array options in axe-core 3.5 know how to handle it for the new object structure. For example, we could give it a key, so that ['foo'] is passed as { value: ['foo'] } into the evaluate function.

@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone Apr 28, 2020
@WilcoFiers WilcoFiers added core Issues in the core code (lib/core) feat New feature or enhancement labels May 4, 2020
@straker straker self-assigned this May 7, 2020
@padmavemulapati
Copy link

devTask

@jeankaplansky
Copy link
Contributor

no user-facing rule help docs required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) feat New feature or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants